chore: don't run tests on travis if only docs were changed #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would it be better to do this if only |
|
I'd prefer to black-list stuff rather than whitelist, particularly since the blacklist is smaller. |
brandonocasey
approved these changes
Jan 3, 2017
|
Um... it should for as much as |
|
Actually, the check is only made on travis, so, should be fine. Should always run tests locally. |
misteroneill
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if we're on travis and if the changes that we're running against only include files in the
docs/folder or are.mdfiles and if so, don't run any tests. Locally, or, if non-doc changes, tests will still run.